Once upon a time I thought Metropolis was Detroit, (primarily because of the Michael Keeton Batman films) and I think originally it was meant to be Chicago, but different writers of the actual stories have their own preferences.

I think Metropolis has generally been meant to be New York. In the new Justice League movies, they've adapted the once (maybe still?) common idea that Gotham and Metropolis are twin cities sharing a bay.